search

ansistrano / deploy

Ansible role to deploy scripting applications like PHP, Python, Ruby, etc. in a capistrano style
https://ansistrano.com
MIT License
2.37k stars 343 forks source link

Fix Ansible 2.8 bare variable deprecation warnings #329

Closed chronon closed 5 years ago

chronon commented 5 years ago

This includes the fix from #328, and fixes a few more. Example deprecation warnings we're seeing:

[DEPRECATION WARNING]: evaluating ansistrano_ensure_shared_paths_exist as a bare variable, this behaviour will go away and you might need to add |bool to the expression in the future. Also
see CONDITIONAL_BARE_VARS configuration toggle.. This feature will be removed in version 2.12. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.
[DEPRECATION WARNING]: evaluating ansistrano_ensure_basedirs_shared_files_exist as a bare variable, this behaviour will go away and you might need to add |bool to the expression in the
future. Also see CONDITIONAL_BARE_VARS configuration toggle.. This feature will be removed in version 2.12. Deprecation warnings can be disabled by setting deprecation_warnings=False in
ansible.cfg.
[DEPRECATION WARNING]: evaluating ansistrano_allow_anonymous_stats as a bare variable, this behaviour will go away and you might need to add |bool to the expression in the future. Also see
CONDITIONAL_BARE_VARS configuration toggle.. This feature will be removed in version 2.12. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.
ricardclau commented 5 years ago

Hi! Do you mind rebasing the last commit in master from #328 ?

This way you will both show up as contributors correctly in each part of the code :)

Thanks!

chronon commented 5 years ago

Done, and thanks for considering all contributors!

ricardclau commented 5 years ago

All contributions are important! No question about it!

Thanks for fixing these annoying warnings!