Unarchive override group and owner

ansistrano / deploy

Ansible role to deploy scripting applications like PHP, Python, Ruby, etc. in a capistrano style

https://ansistrano.com

MIT License

2.37k stars 343 forks source link

Closed dannybrody closed 4 years ago

dannybrody commented 4 years ago

adding the ability to set the owner and group for the unarchive task

ricardclau commented 4 years ago

Please add some tests and try to squash commits, other than that 👍 in adding this feature

ricardclau commented 4 years ago

LGTM! Excellent work, thanks a lot!

Will merge now and tag it either tonight or tomorrow!

ricardclau commented 4 years ago

It looks like tests are failing as the travis and docker environments don't have the nobody users

Any ideas? Did the tests run when you submitted the PR? I don't see them in travis for some reason

ricardclau commented 4 years ago

Never mind, I added explicit users in a pre_task and it all seems to work fine! Thanks again!

dannybrody commented 4 years ago

@ricardclau thank you!