search

ansistrano / deploy

Ansible role to deploy scripting applications like PHP, Python, Ruby, etc. in a capistrano style
https://ansistrano.com
MIT License
2.37k stars 343 forks source link

Update documentation for rsync #344

Closed cubitworx closed 4 years ago

cubitworx commented 4 years ago

One thing that I struggled with for a bit was correctly setting the ansistrano_deploy_from var for use with rsync.

It might be worth adding to the documentation that ansistrano_deploy_from requires a trailing slash if you are using rsync or rsync_direct as your deployment strategy. I couldn't find this mentioned anywhere in the documentation but found this answer in #281 which resolved the problems I was having.

Further adding to the confusion was the fact that the default value of ansistrano_deploy_from is set to playbook_dir which does not have a trailing slash.

ansistrano_deploy_from: "{{ playbook_dir }}"
ricardclau commented 4 years ago

As said in #281 this is standard rsync behavior but since it should not break anything, this was addressed in #345

cubitworx commented 4 years ago

This might be explained in #281 but do you really expect a user to look through all closed issues to find documentation that relates to a particular var? Nowhere in the documentation does it state that ansistrano_deploy_from is used exclusively for rsync.