ansistrano / deploy

Ansible role to deploy scripting applications like PHP, Python, Ruby, etc. in a capistrano style
https://ansistrano.com
MIT License
2.37k stars 343 forks source link

Add region in "Get object from Ceph RGW" task #374

Closed nierdz closed 3 years ago

nierdz commented 3 years ago

Some cloud providers like OpenStack Swift from OVH in EC2 mode needs this region parameter to work.

Here is an example of how we're using this small change in our stack :

ansistrano_deploy_via: s3_unarchive
ansistrano_s3_bucket: "some-bucket"
ansistrano_s3_object: "some-object.tar.gz"
ansistrano_s3_rgw: true
ansistrano_s3_aws_access_key: "{{ vaulted_access_key }}"
ansistrano_s3_aws_secret_key: "{{ vaulted_secret_key }}"
ansistrano_s3_url: "https://s3.gra.cloud.ovh.net"
ansistrano_s3_region: gra
ricardclau commented 3 years ago

I don't have any setup to validate this but your change seems safe so merging it swiftly! Thanks a lot!

nierdz commented 3 years ago

Thanks to you for this instant merge ! :zap:

ricardclau commented 3 years ago

No problem! Sorry the tag is not in Galaxy yet, the folks at Travis decided to start June blocking our pipelines, let's see if they can sort it out or we will move to Github actions (will probably happen soon anyway)

ricardclau commented 3 years ago

Just checked and the tag is definitely in Galaxy... oh well at least you guys have it, thanks again for your contribution