search

ansonphong / postworld

Wordpress Theme Development Framework
GNU General Public License v2.0
7 stars 0 forks source link

load-panel description #27

Closed michelhabib closed 10 years ago

michelhabib commented 10 years ago

Phong, while reviewing my tasks, i think i am a bit confused about load-panel directive. The term panel to me was linked to the search widgets that contain different text fields, selects, checkboxes, etc.. to be used with filtering the feed. And this is how i implemented the panel directive, to be a child of the live-feed directive. and i am sure this is something that is needed anyway. Now re-reading the description, i think you might be referring to another functionality, and i am a bit confused on what it really does. Need your help here.

ansonphong commented 10 years ago

Absolutely - I understand why you may have had some confusion. So load-panel is definitely used for loading search panels, etc. Also, there is another use for load-panel, where sometimes in a layout we want to dynamically load a panel template via AJAX. This is something where the background page would load, and then there would be an area with a loading spinner which then loads in the requested panel. This can load in panels which are un-related to the feeds.

Load-panel could be used for loading any type of panel aka widget especially which might otherwise require some more querying, and you won't want to hold-up the page load, so it's better to put in a loading spinner while it loads.

Does this make sense?

michelhabib commented 10 years ago

Yes. That's good news. I only need to do a little bit of refactoring to the one i created. I want to make sure it is generic to serve the purpose above, but at the same time make sure it can be used for search panels. which it already does. This is the same case as in live-feed/load-feed. Only few tweaks and they will be both ready.

On Mon, Oct 7, 2013 at 6:36 PM, phong notifications@github.com wrote:

Absolutely - I understand why you may have had some confusion. So load-panel is definitely used for loading search panels, etc. Also, there is another use for load-panel, where sometimes in a layout we want to dynamically load a panel template via AJAX. This is something where the background page would load, and then there would be an area with a loading spinner which then loads in the requested panel. This can load in panels which are un-related to the feeds.

Load-panel could be used for loading any type of panel aka _widget_especially which might otherwise require some more querying, and you won't want to hold-up the page load, so it's better to put in a *loading spinner

  • while it loads.

Does this make sense?

— Reply to this email directly or view it on GitHubhttps://github.com/phongmedia/postworld/issues/27#issuecomment-25824044 .

ansonphong commented 10 years ago

Good to hear.