search

ansonphong / postworld

Wordpress Theme Development Framework
GNU General Public License v2.0
7 stars 0 forks source link

function cache_user_post_shares() #58

Closed hmikhail closed 10 years ago

hmikhail commented 10 years ago

Hello @phongmedia, I didn't find documentation for this function cache_user_post_shares(), this function is used in cache_shares.

I will add documentation and implementation for this function.

hmikhail commented 10 years ago

related to issue #32

ansonphong commented 10 years ago

Ok great, thanks for adding that.

On Thursday, October 24, 2013, hmikhail wrote:

Hello phong, I didn't find documentation for this function _cache_user_postshares(), this function is used in _cacheshares.

I will add documentation and implementation for this function.

— Reply to this email directly or view it on GitHubhttps://github.com/phongmedia/postworld/issues/58 .

hmikhail commented 10 years ago

According to docs of share_points_meta incoming : Number of share points to my posts outgoing : From posts that I have shared

Those are set using cache_user_shares according to modes

1- incoming is calculated using function cache_user_shares with $mode = incoming

2- outgoing is calculated using function cache_user_shares with $mode = outgoing

So no need to add additional functions. Could you please confirm so that I can update the documentation ?

ansonphong commented 10 years ago

yes, if there's an extra function here that is redundant you can remove the function and update the docs. thanks for confirming.

On Thu, Oct 24, 2013 at 3:31 AM, hmikhail notifications@github.com wrote:

According to docs of _share_pointsmeta incoming : Number of share points to my posts outgoing : From posts that I have shared

Those are set using cache_user_shares according to modes

1- incoming is calculated using function cache_user_shares with $mode = incoming

  • this calculates user_post_shares

2- outgoing is calculated using function cache_user_shares with $mode = outgoing

  • this calculates user_shares

So no need to add additional functions. Could you please confirm so that I can update the documentation ?

— Reply to this email directly or view it on GitHubhttps://github.com/phongmedia/postworld/issues/58#issuecomment-26981616 .

hmikhail commented 10 years ago

Done in commit bd522454b53a61039a6ebf5bad37f1d640e71b46