ansonphong / postworld

Wordpress Theme Development Framework
GNU General Public License v2.0
7 stars 0 forks source link

Search Query - "undefined" value #82

Closed ansonphong closed 10 years ago

ansonphong commented 10 years ago

Hi Michel, Similar to how we ignored search params which had a value of null, we should also add undefined, which is also causing some results to come empty.

image

michelhabib commented 10 years ago

is this on search page?

ansonphong commented 10 years ago

yes, on the search page. it happens if you switch the 'post format' to something and then back again to nothing.

image

ansonphong commented 10 years ago

BTW - post format isn't working, just waiting on a quick fix from Haidy on that, then we will be renaming it to link_format

ansonphong commented 10 years ago

It seems to be happening also with the author field

image

michelhabib commented 10 years ago

yes, i am handling all the cases now and will keep you posted.

michelhabib commented 10 years ago

i couldnt recreate it, but for now the post_format [actually link_format now] is not generating any undefined values, same for s. All empty and null values are omitted from the query string. if not generated anymore, please close.

ansonphong commented 10 years ago

Great.