Comments Performance

[ansonphong]

Hi Michel, We've currently reached the budget ceiling for both RSV2 and Postworld productions with both Phong Media and Evolver, so this issue is not required and purely voluntary at this stage, listed for documentation as it's something we'll want to address now or in the future.

There seems to be some major performance issues when rendering pages with lots of comments - for instance this post has several hundred comments (mostly spam) so it's a good test case.

http://realitysandwich.com/133925/vibe_not_coincidence_healing/

The page appears to hang when loading the comments, and before I deleted about 100 of the comments, it would actually freeze the browser, reportedly in both Firefox and tested for me in Chrome.

I wonder about different ways how we could be able to increase client-side performance efficiency with the comment system.

[michelhabib]

Hi Phong, I tested the performance of the comments with abount 500 comments - before. The UI would freeze for about a fraction of a second to render the comments hierarchy, i don't recall how long exactly.

Did you add any JS Functionality to the comments on load (per comment)? any simple functionality on this level would be multiplied by the number of comments and might slow it down dramatically. I will have a more detailed look after getting latest code and get back to you. No worries about the budget.

[ansonphong]

I see - yes I added the administrative dropdown menu controller, which generates the menu accessible by the dropdown arrow at the top right of a comment based on the user's permissions in relation to each comment. I should test with and without that menu and see if that effects it. I'll keep the thread updated with my discoveries - I think you're right, it could be something I added - and perhaps we would need to integrate it into the parent controller?

On Sunday, December 15, 2013, michelhabib wrote:

Hi Phong, I tested the performance of the comments with abount 500 comments - before. The UI would freeze for about a fraction of a second to render the comments hierarchy, i don't recall how long exactly.

Did you add any JS Functionality to the comments on load (per comment)? any simple functionality on this level would be multiplied by the number of comments and might slow it down dramatically. I will have a more detailed look after getting latest code and get back to you. No worries about the budget.

— Reply to this email directly or view it on GitHubhttps://github.com/phongmedia/postworld/issues/89#issuecomment-30602251 .

[michelhabib]

If that dropdown is created on load, and uses some javascript, can it be loaded on activation (click) instead? that is if it is the reason of the freezing.

[ansonphong]

Good idea. :)

On 2013-12-15, at 9:16 AM, michelhabib notifications@github.com wrote:

If that dropdown is created on load, and uses some javascript, can it be loaded on activation (click) instead? that is if it is the reason of the freezing.

— Reply to this email directly or view it on GitHub.

[ansonphong]

Also what came to mind - in a future dev cycle we could make the comments appear on the clientside with infinite scrolling. Load them all upfront to the client, but then just progressively reveal as the user scrolls.

On 2013-12-15, at 9:16 AM, michelhabib notifications@github.com wrote:

If that dropdown is created on load, and uses some javascript, can it be loaded on activation (click) instead? that is if it is the reason of the freezing.

— Reply to this email directly or view it on GitHub.