search

anstosa / ferry.fyi

A better tracker for the Washington State Ferry System
https://ferry.fyi
GNU General Public License v3.0
11 stars 3 forks source link

Late ferry (still at dock) shown as having departed early #16

Closed mileserickson closed 5 years ago

mileserickson commented 5 years ago

At 6:27 p.m., ferry.fyi was showing that the 6:10 departure from Mukilteo was predicted to be 28 minutes late, i.e. at 6:38. This is accurate. I'm on board at 6:33 and it's still loading vehicles.

But, it also says that the 6:10 ferry already departed 38 minutes ago at 5:49. That's clearly incorrect.

F1D2FD83-2662-4E16-A3EA-3455266B13FF

anstosa commented 5 years ago

Yup, good catch. Looks like math is wrong because I was categorizing "past" sailings as anything past the scheduled departure date, not past the estimated actual departure date.

anstosa commented 5 years ago

I believe I've fixed this (need to write some mocks and unit tests at some point...). Deploying now

anstosa commented 5 years ago

jk, still broken. hasPassed flag should be false still on this last one (11mins is correct but pointing the wrong direction because of the flag) Screenshot_20190722-172514