search

anstosa / ferry.fyi

A better tracker for the Washington State Ferry System
https://ferry.fyi
GNU General Public License v3.0
11 stars 3 forks source link

Rename App to Application to support building on OS X. Minor updates … #25

Closed srt4 closed 4 years ago

srt4 commented 4 years ago

…to README.md to fix copy command and provide DB initialization instructions

I'm not sure why the App.jsx and App naming doesn't work on the Mac environments I've tried, but it seems like an incompatibility which renaming the component solves. The change is minor and non-functional.

srt4 commented 4 years ago

I'm hesitant to open this up as a PR because it seems like a Mac-specific bug, but it's a small change and it may help others.

mileserickson commented 4 years ago

Hey folks!

Somehow there's a revert commit in there and merging this PR ended up making no changes.

srt4 commented 4 years ago

Hey folks!

Somehow there's a revert commit in there and merging this PR ended up making no changes.

Good catch. I had pushed that change to my fork's master, forgetting that it would affect the scope of this PR. Opened https://github.com/anstosa/ferry.fyi/pull/27

anstosa commented 4 years ago

Wow thanks for the eagle-eye @mileserickson. Glad someone's paying attention 😂