search

answerdigital / terraform-modules

The repo for the infrastructure as code
MIT License
3 stars 4 forks source link

Added Terraform Plan Step for Testing #75

Open robg-test opened 1 year ago

robg-test commented 1 year ago

image

robg-test commented 1 year ago

Should I rename these to test? Suppose they serve 2 purposes here?

cmbuckley commented 1 year ago

Request rebase of this off main to fix the route53 example issue.

This one will need some careful thought as about the intention behind these tests

robg-test commented 1 year ago

Some thoughts:

Route53 change - I'd rather keep this here, the commits won't be squashed so the history will keep track of it as an individual change. this closed PR will contain the required context of why it was fixed.

Name - I believe these should be called test and treated as such, they are effectively sample implementations of the terraform code which can be planned on a an actual AWS account which I believe do add value to the QA of the module.

What to run on change - If the pipeline is dependent on the examples working then you have to run them, if you change an example which is broken and subsequently run a change to a module. Then the CI will break from something not in the current PR which doesn't seem right.

I will update the name of the folders to test and re-request an approval.

robg-test commented 1 year ago

Happy to take a steer from you on this one @cmbuckley whether you think it's worth doing this.

My main motivation for these tests is to let us create working modules proactively.

This raises a question on how we steer this project. It's not necessarily needed if we create modules for projects and use this repo as reference. Then the tests would be the implementation on project.