added performance_insights_enabled argument for rds_instance - #22

[NishantTomar]

added the performance_insights_enabled argument to rds_instance and set the default value as false. ISSUE- #22

[robg-test]

Hi @NishantTomar the workflow we have is running the command terraform fmt for linting.

Can you lint the terraform?

[NishantTomar]

@robg-test I ran the terraform fmt. And hope it passes the workflow this time.

[robg-test]

Hi @NishantTomar we have a small issue in regards to the workflow around forked repos. Will look at fixing it ASAP.

See #78

[robg-test]

Hi @NishantTomar we are a step closer to resolving this issue with the pipeline (@chrisbloe's merge)

[NishantTomar]

Hi @robg-test thanks for the update. I see its still failing in workflow. Let me know if any changes are required.

[robg-test]

Hi again @NishantTomar , we've run into a bit of an issue around execution of this repo from forked repos.

The pipeline is meant to automatically commit documentation changes to the repo however this isn't working as your on a fork. Were going to have a look at next steps for supporting forks next week.

[NishantTomar]

Hi @robg-test is it fixed?

[robg-test]

Hi @NishantTomar

So in order for forked pull requests to work we need to rethink some of the existing behavior around auto-commiting documentation changes. I will add this in scope for release 3 of these modules to come up with a fix for this.

I will replicate this PR in a PR branch directly on this repo.

Apologies, you were the first external editor of this repo and you've helped uncover a rather nasty bug in our workflow.

[robg-test]

See #93 for the new PR and #78 for the issue around not letting you merge in.

[cmbuckley]

Hi @NishantTomar, thank you for your PR! And sorry it took us so long to address the issue described above. I've merged a fix in #95 so documentation is updated automatically for all PRs.

[NishantTomar]

Hi @cmbuckley No problem. It was my pleasure to contribute to the repository.