search

answerdigital / terraform-modules

The repo for the infrastructure as code
MIT License
3 stars 4 forks source link

Update vpc resource names inline with issue #89. #90

Open JoeCSykes opened 1 year ago

Dusty-Meg commented 1 year ago

Are we going to add the moved block in so that it does not break existing uses? https://developer.hashicorp.com/terraform/language/modules/develop/refactoring#moved-block-syntax https://developer.hashicorp.com/terraform/language/modules/develop/refactoring#removing-moved-blocks

JoeCSykes commented 1 year ago

Are we going to add the moved block in so that it does not break existing uses? https://developer.hashicorp.com/terraform/language/modules/develop/refactoring#moved-block-syntax https://developer.hashicorp.com/terraform/language/modules/develop/refactoring#removing-moved-blocks

I believe this is going to be in another PR. This PR just changes the resource name.

robg-test commented 1 year ago

The agreed approach was to bump up a major version to not have to deal with the moved block, as far as I'm aware.

JoeCSykes commented 1 year ago

This is my PR so I can't approve it, but I have checked and this looks good to me 👍