search

ansys / actions

A collection of reusable workflows
https://actions.docs.ansys.com/
MIT License
10 stars 5 forks source link

refactor: remove level from code-style action #545

Open SMoraisAnsys opened 3 weeks ago

SMoraisAnsys commented 3 weeks ago

While asking for an update in vale-action, I discovered that level is no longer an input of this action, see https://github.com/errata-ai/vale-action/commit/c4213d4de3d5f718b8497bd86161531c78992084.

I've opened an issue to update the version of reviewdog in vale-action. If this occurs, vale-action could leverage the new feature fail-level which could lead to level being added back. However, this is just an issue and I don't know what the maintainer will decide, see https://github.com/errata-ai/vale-action/issues/131 for more information.

In the mean time, I propose we remove this misleading input which gave me the impression that we could chose the level on which the action will fail.

ansys-reviewer-bot[bot] commented 3 weeks ago

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

RobPasMue commented 3 weeks ago

Can't we wait to see what the vale maintainer decides? I wouldn't want to duplicate efforts on this.

jorgepiloto commented 2 weeks ago

Can't we wait to see what the vale maintainer decides? I wouldn't want to duplicate efforts on this.

Agreed. Let's leave this in draft for the moment until Vale and Reviewdog take a final decission.

Thanks for noticing this unused input parameter, Sebastien.

SMoraisAnsys commented 2 weeks ago

Can't we wait to see what the vale maintainer decides? I wouldn't want to duplicate efforts on this.

Agreed. Let's leave this in draft for the moment until Vale and Reviewdog take a final decission.

Thanks for noticing this unused input parameter, Sebastien.

I'll work on vale-action to add this feature. The maintainer doesn't seem to be opposed to adding a fail-level !