search

ansys / actions

A collection of reusable workflows
https://actions.docs.ansys.com/
MIT License
13 stars 5 forks source link

feat: whitelist packages on check-licenses action #600

Closed RobPasMue closed 3 weeks ago

RobPasMue commented 3 weeks ago

Closes #516

Testing done in https://github.com/ansys/pyansys-tools-report/pull/219

ansys-reviewer-bot[bot] commented 3 weeks ago

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

RobPasMue commented 3 weeks ago

@MaxJPRey @SMoraisAnsys - packages (both ignored and whitelisted) are being printed out on the logs already. I don't understand what else you want... Feel free to reach out internally.

https://github.com/ansys/pyansys-tools-report/actions/runs/11177206820/job/31072221914?pr=219#step:2:829

RobPasMue commented 3 weeks ago

I like this approach, the one that I had in mind was to allow licenses instead of packages but I think I prefer your approach.

Yeah... let's go package by package instead. Otherwise it could lead to leaks I think. If a license needs to be accepted globally we can add it to the list of accepted licenses later on.

MaxJPRey commented 3 weeks ago

Thanks for all the modifications @RobPasMue!