search

ansys / ansys-api-tools-filetransfer

Ansys file transfer protofiles
MIT License
1 stars 0 forks source link

Remove result and progress messages, change type for sizes and hash #4

Closed greschd closed 2 years ago

greschd commented 2 years ago

Remove the Result message in favor of using gRPC status codes.

Change all unsigned integer types to be signed, following https://cloud.google.com/apis/design/design_patterns#integer_types

Change the type of the SHA1 hexdigest to string, to avoid encoding issues.

greschd commented 2 years ago

@ansutremel for the download, I think we could also get away with a single message instead of a stream as a request. The "ReceiveData" and "Finalize" messages don't convey any information besides "keep going". What's your take on that?