search

ansys / ansys-sphinx-theme

PyData-based Sphinx theme from the PyAnsys community
https://sphinxdocs.ansys.com
MIT License
22 stars 5 forks source link

Make card dimensions adaptable to all devices #256

Closed klmcadams closed 2 weeks ago

klmcadams commented 1 year ago

Description of the modifications

The cards on the main pyansys page (https://docs.pyansys.com/version/stable/) are squished when viewed on a mobile phone (see attached). We could make it so it only shows two cards per row, and/or adjust the css to be flexible and adapt to the size of the device being used.

image

Useful links and references

https://docs.pyansys.com/version/stable/

Revathyvenugopal162 commented 1 year ago

Thanks for opening issue @klmcadams , @AlejandroFernandezLuces already mentioned this issue, and i am working on this.

MaxJPRey commented 1 year ago

@Revathyvenugopal162 When it is done, might be worth it to do some additional testing about other contents and pages. For instance, make sure that the dev guide is rendering properly and we did not downgraded any UI/UX part.

RobPasMue commented 1 year ago

Testing on different devices might be difficult in terms of CI/CD. But we should explore this. I'm no expert on CSS but happy to learn

Revathyvenugopal162 commented 1 year ago

It is already doing with pydata, we do have an open issue to adapt tests, we are adding this with different devices when we are modifying with pydata, but for sphinx cards, they dont have customization, so we just have to adapt their tests only for the sphinx design, until they have some from their side.

Revathyvenugopal162 commented 2 weeks ago

Thank you for opening the issue, fixed with v1.0.5 and closing the issue.