ansys / ansys-sphinx-theme

PyData-based Sphinx theme from the PyAnsys community
https://sphinxdocs.ansys.com
MIT License
22 stars 5 forks source link

Tables are in light theme when dark theme is selected #317

Closed rcrisanti closed 10 months ago

rcrisanti commented 11 months ago

🔍 Before submitting the issue

🐞 Description of the bug

When you have a table and dark mode is selected, the table background is light, as is the text. The issue seems very similar to https://github.com/ansys/ansys-sphinx-theme/issues/203, but it was working fine a month or two ago, not sure what changed.

📝 Steps to reproduce

Screenshot 2023-10-30 at 1 54 27 PM

It's visible on the ansys-sphinx-theme documentation page under the table example, but I have also reproduced it locally.

💻 Which operating system are you using?

MacOS

📀 Which ANSYS version are you using?

No response

🐍 Which Python version are you using?

3.9

📦 Installed packages

accessible-pygments==0.0.4
alabaster==0.7.13
ans.protocol.amk==0.1.0b9
ansys-materials-manager==0.2.3
-e git+ssh://git@github.com/ansys-internal/pysimbuilder.git@4f1c6b63a8705a287775b28b8a70c9fbbfb5999e#egg=ansys_simbuilder_core&subdirectory=packages/sim_builder
ansys-sphinx-theme==0.12.4
attrs==23.1.0
Babel==2.13.1
beautifulsoup4==4.12.2
black==23.1.0
cattrs==23.1.2
certifi==2023.7.22
charset-normalizer==3.3.1
click==8.1.7
contourpy==1.1.1
coverage==7.3.2
cycler==0.12.1
docstring-to-markdown==0.13
docutils==0.18.1
exceptiongroup==1.1.3
fancycompleter==0.9.1
flake8==5.0.4
flake8-per-file-ignores==0.7
flatbuffers==23.5.26
fonttools==4.43.1
graphviz==0.20.1
grpcio==1.59.0
idna==3.4
imagesize==1.4.1
importlib-metadata==6.8.0
importlib-resources==6.1.0
iniconfig==2.0.0
jedi==0.19.1
Jinja2==3.1.2
jsondiff==2.0.0
kiwisolver==1.4.5
lsprotocol==2023.0.0b1
markdown-it-py==3.0.0
MarkupSafe==2.1.3
matplotlib==3.8.0
mccabe==0.7.0
mdit-py-plugins==0.4.0
mdurl==0.1.2
mypy==1.4.0
mypy-extensions==1.0.0
myst-parser==2.0.0
numpy==1.26.1
packaging==23.2
pandas==2.1.2
parso==0.8.3
pathmatch==0.2.2
pathspec==0.11.2
pdbpp==0.10.3
Pillow==10.1.0
platformdirs==3.11.0
pluggy==1.3.0
pockets==0.9.1
prettytable==3.9.0
protobuf==4.24.4
pycodestyle==2.9.1
pydata-sphinx-theme==0.14.2
pydot==1.4.2
pyflakes==2.5.0
Pygments==2.16.1
pyparsing==3.1.1
pyrepl==0.9.0
pytest==7.4.3
pytest-asyncio==0.21.1
pytest-cov==4.1.0
python-dateutil==2.8.2
python-lsp-jsonrpc==1.1.2
python-lsp-ruff==1.6.0
python-lsp-server==1.8.2
pytz==2023.3.post1
PyYAML==6.0.1
requests==2.31.0
ruff==0.1.2
rustworkx==0.12.0
semantic-version==2.10.0
semver==3.0.2
setuptools-rust==1.7.0
six==1.16.0
snowballstemmer==2.2.0
soupsieve==2.5
Sphinx==7.2.6
sphinx-autodoc-typehints==1.24.0
sphinx-copybutton==0.5.2
sphinx-rtd-theme==1.3.0
sphinx_design==0.5.0
sphinx_subfigure==0.2.4
sphinxcontrib-applehelp==1.0.7
sphinxcontrib-devhelp==1.0.5
sphinxcontrib-htmlhelp==2.0.4
sphinxcontrib-jquery==4.1
sphinxcontrib-jsmath==1.0.1
sphinxcontrib-napoleon==0.7
sphinxcontrib-qthelp==1.0.6
sphinxcontrib-serializinghtml==1.1.9
tomli==2.0.1
typing==3.7.4.3
typing_extensions==4.7.1
tzdata==2023.3
ujson==5.8.0
urllib3==2.0.7
wcwidth==0.2.8
wmctrl==0.5
zipp==3.17.0
rcrisanti commented 11 months ago

By installing previous versions, it seems like this was introduced in v0.12.0, so I have a temporary workaround for now by pinning to v0.11.2

RobPasMue commented 11 months ago

That's when we changed the PyData Sphinx Theme version used. @Revathyvenugopal162 please investigate.

Revathyvenugopal162 commented 11 months ago

Thanks for pointing this issue @rcrisanti , i will investigate and update .