Open mia-guo-ux opened 2 weeks ago
Card
Buttons
Links
Side nav
Select
One thing is, the dropdown select component in Sphinx looks like an accordion component.
Our proposed selector looks like this:
Dropdown
Table
Scrollbar
Breadcrumb
Tabs
Generic guidelines
Example pages
Thanks for this great review, @mia-guo-ux.
The only thing I do not agree is the text-align of the code blocks content. In my opinion, this should be left-aligned. Otherwise, we are loosing a precious space. Some statements can be quite long, so it is better to use all the available space. I am fine though adding some padding. What do you think?
Thanks for this great review, @mia-guo-ux.
The only thing I do not agree is the text-align of the code blocks content. In my opinion, this should be left-aligned. Otherwise, we are loosing a precious space. Some statements can be quite long, so it is better to use all the available space. I am fine though adding some padding. What do you think?
I agree with Jorge - code-snippets should be left aligned IMO
Great catch! Here's an updated screen. Besides this, please feel free to let me know if any of the updates is technically feasible and if any adjustment is needed :)
Have we addressed all the changes @Revathyvenugopal162 @jorgepiloto ?
Have we addressed all the changes @Revathyvenugopal162 @jorgepiloto ?
We are addressing issues one by one. Thank you for notifying @RobPasMue, though it was mistakenly mentioned in the PR.
Thanks for this great review, @mia-guo-ux. The only thing I do not agree is the text-align of the code blocks content. In my opinion, this should be left-aligned. Otherwise, we are loosing a precious space. Some statements can be quite long, so it is better to use all the available space. I am fine though adding some padding. What do you think?
I agree with Jorge - code-snippets should be left aligned IMO
Code blocks, captions, images, tables -- all should be left-aligned!
The code snippet has been fixed. Please let me know if anything needs to be updated. :)
Table
PR #408
Changes made:
Generic guidelines
PR #409
changes made:
Side nav
@mia-guo-ux , the color you mentioned for the active and hover states in the sidebar is the same, but it appears different in the image. Could you please clarify?
Links
@mia-guo-ux , For links, we have two additional states: visited links and visited hover links. Could you please check these and provide design suggestions for them as well?
Side nav
@mia-guo-ux , the color you mentioned for the active and hover states in the sidebar is the same, but it appears different in the image. Could you please clarify?
Sorry for the confusion. The image has been updated. In Hover states, the bg fill is #ECECEC, but in Active states, it should be #D9D9D9
Links
@mia-guo-ux , For links, we have two additional states: visited links and visited hover links. Could you please check these and provide design suggestions for them as well?
The design has been updated. Please see the image in the original post :)
Hi @Revathyvenugopal162 I made a few updates to Tabs, Side nav, Links, and Global Nav. Please refer to the original post (the images have been re-uploaded). Thank you :)
In addition, here's the admonition component
Links
PR #411
Task list
Sphinx design : https://sphinxdocs.ansys.com/version/dev/examples/sphinx-design.html#
The following components could be enhanced to create a more streamlined user experience.
Please feel free to let me know if you have any concerns or if anything needs to be specified. Cheers! FYI @Revathyvenugopal162 @jorgepiloto @RobPasMue