ansys / ansys-templates

A tool for creating new projects according to Ansys guidelines
https://templates.ansys.com
MIT License
11 stars 4 forks source link

chore: update templates #471

Closed klmcadams closed 2 months ago

klmcadams commented 2 months ago

ansys-templates changes

src/ansys/templates/python/common changes

ci_cd.yml updates

doc updates

conf.py updates

pyproject.toml updates

misc changes

Here is a sample repo that I created using this branch and running ansys-templates new pyansys-advanced. The product name was template, and library was sandbox: https://github.com/ansys-internal/pytemplate-sandbox

RobPasMue commented 2 months ago

@iazehaf - you might need to update your documentation build to add the changelog.rst file. This is what is failing in your status

SMoraisAnsys commented 2 months ago

Cannot propose a change myself (out of reach through Github GUI) but could you also change the maintainers from

maintainers = [
    {name = "PyAnsys developers", email = "pyansys.core@ansys.com"},
]

to

maintainers = [
    {name = "ANSYS, Inc.", email = "pyansys.core@ansys.com"},
]

Came across that just now as I was review a project and it seems that "ANSYS, Inc" should be used for maintainers, cf https://dev.docs.pyansys.com/getting-started/administration.html#technical

SMoraisAnsys commented 2 months ago

@klmcadams Last comment I promise ! Could you also update the doc/.vale.ini to avoid using Vale.Terms by default ?

Vale.Terms = NO
jorgepiloto commented 2 months ago

Thanks for the great work in here, @klmcadams.