feat: tech review - Githubissues

ansys / ansys-tools-filetransfer

Python Client for the Ansys Filetransfer Tool

https://filetransfer.tools.docs.pyansys.com/

MIT License

0 stars 0 forks source link

feat: tech review #67

Closed RobPasMue closed 7 months ago

RobPasMue commented 7 months ago

Congratulations @greschd - this is probably my fastest Python repo to review. Everything was in line with what is expected.

RobPasMue commented 7 months ago

Minor modifications_

LICENSE file end year - our hook should be able to modify this by the end of year
Removing private PyPI from pyproject.toml file
Setting dependabot on a weekly basis
Docstring alignment in the source code
Use ansys/actions for doc build

greschd commented 7 months ago

was in line with what is expected

Cool 🥳

Use ansys/actions for doc build

Seems to be failing currently because we use extras instead of groups. FMPOV we can just change that, I think the reason is legacy (started with a pre-groups poetry version).

RobPasMue commented 7 months ago

Okay so I ended up reverting the doc-build using our actions. Just because you need to define your dependencies the "poetry" way using groups. But I believe it is more platform agnostic using "extras" since that way you could even do "pip install .[doc]" w/o needing poetry. Anyway, all good. Just food for thought :)

greschd commented 7 months ago

Thanks a lot @RobPasMue!