search

ansys / ansys-tools-path

Library to detect Ansys products installation path
https://path.tools.docs.pyansys.com/
MIT License
3 stars 2 forks source link

Support for Python 3.12 and drop Python 3.8 #171

Closed RobPasMue closed 1 month ago

RobPasMue commented 4 months ago

@koubaa @germa89 @nmalsang

According to ADR-21, this package should be supporting at least Python 3.12 actively (i.e. building the wheelhouse). Also, lowest supported Python version should be 3.9 - Python 3.8 is close to EOL and its support is not recommended anymore.

koubaa commented 4 months ago

@RobPasMue ansys-tools-path is used in an ADO build pipeline that runs on ubuntu AKS build agents. The version of ubuntu that is used is 18.04 which has up to python3.8 in apt. I'll try to find out if those can be updated

greschd commented 4 months ago

I think adding support for 3.12 is the more important bit here.

koubaa commented 4 months ago

@Gryfenfer97 could you please add 3.12 support and patch the release?

Gryfenfer97 commented 4 months ago

@Gryfenfer97 could you please add 3.12 support and patch the release?

The tests already pass with python 3.12, the only edit I can see is to add a line in the pyproject.toml to specify in the pypi page that we support python 3.12 + the CI/CD

RobPasMue commented 4 months ago

https://github.com/ansys/ansys-tools-path/blob/fe6571262916d0861885eb95e207bbde0eda526f/.github/workflows/ci_cd.yml#L31

We are not performing wheelhouses or smoke tests with 3.12

Plus, as you mention, the metadata in the pyproject.toml file should be updated accordingly