ansys / ansys-tools-path

Library to detect Ansys products installation path
https://path.tools.docs.pyansys.com/
MIT License
3 stars 2 forks source link

find_mechanical doesn't check for 241 #59

Closed rs-bh-n closed 1 year ago

rs-bh-n commented 1 year ago

πŸ” Before submitting the issue

🐞 Description of the bug

find_mechanical does not find an installed version : unreleased 241

image

I also noticed that a) the path.py in ansys/tools doesn't list 241 as a supported version . image

b) _version.py in repo too doesnt list it as a supported version

image

πŸ“ Steps to reproduce

shown in the snapshot above

πŸ’» Which operating system are you using?

Windows

πŸ“€ Which ANSYS version are you using?

Ansys 232 and 241

🐍 Which Python version are you using?

3.10

πŸ“¦ Installed packages

accessible-pygments==0.0.4
alabaster==0.7.13
ansys-api-mechanical==0.1.0
ansys-api-platform-instancemanagement==1.0.0b3
-e git+https://github.com/pyansys/pymechanical.git@e0bbbc1c35fd30787c73586486bee833eaa6c060#egg=ansys_mechanical_core
ansys-platform-instancemanagement==1.1.1
ansys-pythonnet==3.1.0rc1
ansys-sphinx-theme==0.9.9
ansys-tools-path==0.2.4
anyio==3.7.0
appdirs==1.4.4
argon2-cffi==21.3.0
argon2-cffi-bindings==21.2.0
arrow==1.2.3
asttokens==2.2.1
async-lru==2.0.2
attrs==23.1.0
Babel==2.12.1
backcall==0.2.0
beautifulsoup4==4.12.2
bleach==6.0.0
cachetools==5.3.1
certifi==2023.5.7
cffi==1.15.1
cfgv==3.3.1
chardet==5.1.0
charset-normalizer==3.1.0
clr-loader==0.2.5
colorama==0.4.6
comm==0.1.3
contourpy==1.1.0
cycler==0.11.0
debugpy==1.6.7
decorator==5.1.1
defusedxml==0.7.1
distlib==0.3.6
docutils==0.19
exceptiongroup==1.1.1
executing==1.2.0
fastjsonschema==2.17.1
filelock==3.12.2
flit==3.9.0
flit_core==3.9.0
fonttools==4.40.0
fqdn==1.5.1
googleapis-common-protos==1.59.1
grpcio==1.54.2
identify==2.5.24
idna==3.4
imageio==2.31.1
imageio-ffmpeg==0.4.8
imagesize==1.4.1
importlib-metadata==6.6.0
iniconfig==2.0.0
install==1.3.5
ipydatawidgets==4.3.5
ipykernel==6.23.2
ipython==8.14.0
ipywidgets==8.0.6
isoduration==20.11.0
jaraco.classes==3.2.3
jedi==0.18.2
Jinja2==3.1.2
json5==0.9.14
jsonpointer==2.3
jsonschema==4.17.3
jupyter-events==0.6.3
jupyter-lsp==2.2.0
jupyter-sphinx==0.4.0
jupyter_client==8.2.0
jupyter_core==5.3.1
jupyter_server==2.6.0
jupyter_server_terminals==0.4.4
jupyterlab==4.0.2
jupyterlab-pygments==0.2.2
jupyterlab-widgets==3.0.7
jupyterlab_server==2.23.0
keyring==23.13.1
kiwisolver==1.4.4
livereload==2.6.3
markdown-it-py==3.0.0
MarkupSafe==2.1.3
matplotlib==3.7.1
matplotlib-inline==0.1.6
mdurl==0.1.2
mistune==2.0.5
more-itertools==9.1.0
nbclient==0.8.0
nbconvert==7.5.0
nbformat==5.9.0
nest-asyncio==1.5.6
nodeenv==1.8.0
notebook_shim==0.2.3
numpy==1.24.3
numpydoc==1.5.0
overrides==7.3.1
packaging==23.1
pandocfilters==1.5.0
parso==0.8.3
pickleshare==0.7.5
Pillow==9.5.0
pkginfo==1.9.6
platformdirs==3.5.3
plotly==5.15.0
pluggy==1.0.0
pooch==1.7.0
pre-commit==3.3.3
prometheus-client==0.17.0
prompt-toolkit==3.0.38
protobuf==3.20.3
protoc-gen-swagger==0.1.0
psutil==5.9.5
pure-eval==0.2.2
pycparser==2.21
pydata-sphinx-theme==0.13.3
Pygments==2.15.1
pypandoc==1.11
pyparsing==3.0.9
pyproject-api==1.5.2
pyrsistent==0.19.3
pytest==7.3.2
pytest-sphinx==0.5.0
python-dateutil==2.8.2
python-json-logger==2.0.7
pythreejs==2.4.2
pyvista==0.39.1
pywin32==306
pywin32-ctypes==0.2.0
pywinpty==2.0.10
PyYAML==6.0
pyzmq==25.1.0
readme-renderer==37.3
requests==2.31.0
requests-toolbelt==1.0.0
rfc3339-validator==0.1.4
rfc3986==2.0.0
rfc3986-validator==0.1.1
rich==13.4.2
scooby==0.7.2
Send2Trash==1.8.2
six==1.16.0
sniffio==1.3.0
snowballstemmer==2.2.0
soupsieve==2.4.1
Sphinx==6.2.1
sphinx-autobuild==2021.3.14
sphinx-autodoc-typehints==1.23.0
sphinx-copybutton==0.5.2
sphinx-gallery==0.13.0
sphinx-notfound-page==0.8.3
sphinx_design==0.4.1
sphinxcontrib-applehelp==1.0.4
sphinxcontrib-devhelp==1.0.2
sphinxcontrib-htmlhelp==2.0.1
sphinxcontrib-jsmath==1.0.1
sphinxcontrib-qthelp==1.0.3
sphinxcontrib-serializinghtml==1.1.5
sphinxcontrib-websupport==1.2.4
sphinxemoji==0.2.0
stack-data==0.6.2
tenacity==8.2.2
terminado==0.17.1
tinycss2==1.2.1
tomli==2.0.1
tomli_w==1.0.0
tornado==6.3.2
tox==4.6.0
tqdm==4.65.0
traitlets==5.9.0
traittypes==0.2.1
twine==4.0.2
typing_extensions==4.6.3
uri-template==1.2.0
urllib3==2.0.3
virtualenv==20.23.0
vtk==9.2.6
wcwidth==0.2.6
webcolors==1.13
webencodings==0.5.1
websocket-client==1.5.3
widgetsnbextension==4.0.7
zipp==3.15.0
RobPasMue commented 1 year ago

We should include support for 241 in this package. @klmcadams could you take care of this? It has to be added here:

https://github.com/ansys/ansys-tools-path/blob/b492239651bf0cbe0d08fd71e37fa59d6c3fc67f/src/ansys/tools/path/path.py#L21-L35

germa89 commented 1 year ago

Ey @RobPasMue!, we are planning a patch release for ansys-tools-path so if you don't mind, @Gryfenfer97 will fix this issue so we can have the patch release by the end of the day (internal request).

RobPasMue commented 1 year ago

As discussed with @germa89 privately, let's leave it to @klmcadams for now. Let's try having it done ASAP. Implementation should be quick.