search

ansys / optical-automation

Optical Automation Framework
https://ansys-internal.github.io/optical-automation/
MIT License
29 stars 11 forks source link

Bsdf converter #142

Closed SandAuriol closed 1 year ago

SandAuriol commented 1 year ago

@StefanThoene I'm creating a pull request for the BSDF code. There is only one unit test that checks that converts a Zemax file into a Speos anisotropicbsdf. It checks the created file with a reference. I will need to add more tests for the other configurations. But I thought it would be a good start.

SandAuriol commented 1 year ago

I don't know why the pre-commit fails here because it works on my side.

pluAtAnsys commented 1 year ago

I don't know why the pre-commit fails here because it works on my side.

resolved with pre-commit autoupdate

SandAuriol commented 1 year ago

Hi @pluAtAnsys! Could you help me with these errors? The unit tests don't pass. Test 12 works on my computer.

SandAuriol commented 1 year ago

Hey @StefanThoene! The checks have passed :-) If you have time to have a look, that would be great. No worries if not.