ansys / pyacp

Python Client for Ansys Composite PrepPost
https://acp.docs.pyansys.com
MIT License
4 stars 1 forks source link

API Documentation #330

Open janvonrickenbach opened 7 months ago

janvonrickenbach commented 7 months ago
greschd commented 7 months ago

Thanks @janvonrickenbach, agree with everything mentioned.

Regarding the package structure, we might consider adding one more level, for example:

- material_data - layup_definition - solid_model - inspection (section cut, plots, ply book, ...)

The structure on the Model should then be the same.

EDIT: After discussion, we decided not to add this extra layer since it doesn't really improve discoverability. The groups would be unbalanced, layup_definition being by far the largest.

Additionally, I wonder if the enums.py should be split apart, and each enum moved to where it is used. EDIT: this part we can do, but it's not critical since the canonical import name is anyway at the root level of the module.