Closed greschd closed 2 weeks ago
Attention: Patch coverage is 66.66667%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 94.49%. Comparing base (
46d8d0e
) to head (cbf112f
). Report is 1 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
src/ansys/acp/core/_server/direct.py | 50.00% | 1 Missing :warning: |
src/ansys/acp/core/example_helpers.py | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Add usage of the
check-vulnerabilities
action, to check for code vulnerabilities.Checks for the use of
assert
are globally disabled. The reason for this check is thatassert
can be misused to check for invalid input, but we use it to validate programmer assumptions (i.e., they should never raise unless there is a bug).For the identified issues which were ignored (related to launching the ACP gRPC server executable), a "security considerations" page is added to the documentation.
Since we are not certain if the
check-vulnerabilities
action works onmain
with current permissions, CI is configured to continue when it fails.