ansys / pyacp

Python Client for Ansys Composite PrepPost
https://acp.docs.pyansys.com
MIT License
5 stars 1 forks source link

Add vulnerability check CI job #650

Closed greschd closed 2 weeks ago

greschd commented 3 weeks ago

Add usage of the check-vulnerabilities action, to check for code vulnerabilities.

Checks for the use of assert are globally disabled. The reason for this check is that assert can be misused to check for invalid input, but we use it to validate programmer assumptions (i.e., they should never raise unless there is a bug).

For the identified issues which were ignored (related to launching the ACP gRPC server executable), a "security considerations" page is added to the documentation.

Since we are not certain if the check-vulnerabilities action works on main with current permissions, CI is configured to continue when it fails.

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.49%. Comparing base (46d8d0e) to head (cbf112f). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/acp/core/_server/direct.py 50.00% 1 Missing :warning:
src/ansys/acp/core/example_helpers.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #650 +/- ## ======================================= Coverage 94.49% 94.49% ======================================= Files 99 99 Lines 5417 5417 ======================================= Hits 5119 5119 Misses 298 298 ``` | [Flag](https://app.codecov.io/gh/ansys/pyacp/pull/650/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansys) | Coverage Δ | | |---|---|---| | [python-3.10](https://app.codecov.io/gh/ansys/pyacp/pull/650/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansys) | `94.27% <50.00%> (-0.12%)` | :arrow_down: | | [python-3.11](https://app.codecov.io/gh/ansys/pyacp/pull/650/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansys) | `94.31% <66.66%> (?)` | | | [python-3.12](https://app.codecov.io/gh/ansys/pyacp/pull/650/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansys) | `94.42% <66.66%> (ø)` | | | [server-2024R2](https://app.codecov.io/gh/ansys/pyacp/pull/650/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansys) | `91.08% <50.00%> (ø)` | | | [server-2025R1](https://app.codecov.io/gh/ansys/pyacp/pull/650/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansys) | `94.31% <66.66%> (ø)` | | | [server-latest](https://app.codecov.io/gh/ansys/pyacp/pull/650/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansys) | `94.38% <66.66%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansys#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.