ansys / pyacp

Python Client for Ansys Composite PrepPost
https://acp.docs.pyansys.com
MIT License
5 stars 1 forks source link

Polish pyacp module #670

Open roosre opened 1 week ago

roosre commented 1 week ago
greschd commented 1 week ago

@roosre agreed overall, just some minor points:

Class ACP -> rename to ACPServer or ACPInstance

That was actually called ACPServer at some point (or ACPInstance, I don't remember), before we merged the "client" and "server" functionality into one. I'm now a bit on the fence whether we should rename it back.

Enums -> Move to separate namespace?

For this one I think I'll want to create a branch with the change and see how it changes the example code (when enums are used, not strings). I think it's not entirely clear whether to put all enums in one namespace, or group them by usage (e.g. all solid model - related enums). The former is somewhat odd, but grouping by usage will be difficult to remember especially since the main types are all top-level.

example_helpers -> move to separate namesapce

This is a separate namespace already.

roosre commented 1 week ago

@greschd , thanks for the response.

Enum: I wanted to remove this point from the list and keep it as it is. Sorry about that.

ACP -> ACPClient / ACP Instance: thanks for the info. Good to know and so let's discuss it next week.

greschd commented 10 hours ago

@roosre is this one and #637 done, or is something left to do from your point of view?