ansys / pyacp

Python Client for Ansys Composite PrepPost
https://acp.docs.pyansys.com
MIT License
5 stars 1 forks source link

Fix tree printer to include all object types #679

Open greschd opened 1 week ago

greschd commented 1 week ago

Change the implementation of 'get_model_tree' to use the '_GRPC_PROPERTIES' class attribute, and thus include all newly-added object types in the representation.

The style of the tree has changed in some ways:

To discuss:

The new tree structure can be seen in the updated test cases, or in print_model.rst.

Partially addresses #348, interactive tree support in Jupyter notebooks is still missing.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 88.46154% with 3 lines in your changes missing coverage. Please review.

Project coverage is 94.76%. Comparing base (699324d) to head (31c84a9).

Files with missing lines Patch % Lines
src/ansys/acp/core/_model_printer.py 88.46% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #679 +/- ## ========================================== - Coverage 94.83% 94.76% -0.07% ========================================== Files 104 104 Lines 5688 5657 -31 ========================================== - Hits 5394 5361 -33 - Misses 294 296 +2 ``` | [Flag](https://app.codecov.io/gh/ansys/pyacp/pull/679/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansys) | Coverage Δ | | |---|---|---| | [python-3.10](https://app.codecov.io/gh/ansys/pyacp/pull/679/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansys) | `94.55% <88.46%> (-0.07%)` | :arrow_down: | | [python-3.11](https://app.codecov.io/gh/ansys/pyacp/pull/679/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansys) | `94.48% <88.46%> (-0.07%)` | :arrow_down: | | [python-3.12](https://app.codecov.io/gh/ansys/pyacp/pull/679/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansys) | `94.69% <88.46%> (-0.07%)` | :arrow_down: | | [server-2024R2](https://app.codecov.io/gh/ansys/pyacp/pull/679/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansys) | `91.19% <88.46%> (-0.09%)` | :arrow_down: | | [server-2025R1](https://app.codecov.io/gh/ansys/pyacp/pull/679/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansys) | `94.48% <88.46%> (-0.07%)` | :arrow_down: | | [server-2025R2](https://app.codecov.io/gh/ansys/pyacp/pull/679/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansys) | `94.48% <88.46%> (-0.07%)` | :arrow_down: | | [server-latest](https://app.codecov.io/gh/ansys/pyacp/pull/679/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansys) | `94.55% <88.46%> (-0.07%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansys#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: