Closed greschd closed 5 days ago
Attention: Patch coverage is 90.90909%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 94.51%. Comparing base (
fa58a45
) to head (e977049
). Report is 1 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
src/ansys/acp/core/_tree_objects/cad_geometry.py | 66.66% | 2 Missing :warning: |
src/ansys/acp/core/_utils/pyvista_import_check.py | 85.71% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
Make the
pyvista
dependency optional, adding theplotting
extra dependency group to install it.Add a
requires_pyvista
decorator, which is added to functions which import PyVista internally. The user is advised to runpip install ansys-acp-core[plotting]
to install PyVista if it is missing.Mark tests which require PyVista with
pytest.mark.plotting
, and add a separate set of CI tests which:main
dependency group is installedmain
andtest
dependency groups, with-m "not plotting"
to exclude plot testsRemove the duplication of dependencies between the
extras
and thedev
dependency, since that didn't work properly. Instead add--all-extras
or--extras <extra_name>
topoetry install
where needed.Move some internal utilities from the top-level
ansys.acp.core
to theansys.acp.core._utils
module.