ansys / pyadditive

Pythonic interface client to Ansys additive simulation service
https://additive.docs.pyansys.com
MIT License
2 stars 1 forks source link

User Provided Thermal Parameters should be mentioned explicitly. #310

Open safeerehman opened 5 months ago

safeerehman commented 5 months ago

๐Ÿ“ Description of the feature

Currently, ParametricStudy::generate_microstructure_permutations takes the input cooling_rate, thermal_gradient, melt_pool_width and melt_pool_depth as arguments and passes it on to create a MicrostructureInput.

MicrostructureInput however has an additional argument use_provided_thermal_parameters, a boolean field that is set to False by default and True only if the user provides the above four arguments explicitly.

ParametricStudy::generate_microstructure_permutations sets the use_provided_thermal_parameters internally depending upon if the arguments have a nan or a None or an actual value specified and passes it while creating the MicrostructureInput

This needs to be enhanced by having the user explicitly mention use_provided_thermal_parameters in ParametricStudy::generate_microstructure_permutations along with the values of each of the four arguments.

The study data frame should have an additional column for use_provided_thermal_parameters and the fields for cooling_rate, thermal_gradient, melt_pool_width and melt_pool_depth should not be empty.

๐Ÿ’ก Steps for implementing the feature

๐Ÿ”— Useful links and references

No response

pkrull-ansys commented 4 months ago

@safeerehman Did this get implemented?

safeerehman commented 4 months ago

@pkrull-ansys, not yet.