search

ansys / pyaedt

AEDT Python Client Package
https://aedt.docs.pyansys.com
MIT License
185 stars 101 forks source link

REFACTOR: PCB Component #4864

Open lorenzovecchietti opened 6 days ago

ansys-reviewer-bot[bot] commented 6 days ago

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 33.03571% with 150 lines in your changes missing coverage. Please review.

Project coverage is 37.41%. Comparing base (c4d9686) to head (97fdb29). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4864 +/- ## =========================================== - Coverage 83.16% 37.41% -45.75% =========================================== Files 118 118 Lines 54144 54299 +155 =========================================== - Hits 45030 20318 -24712 - Misses 9114 33981 +24867 ```
lorenzovecchietti commented 3 days ago

@SMoraisAnsys, documentation build is failing for missing docstrings even if docstrings are there. Do you have any suggestion to help me?

SMoraisAnsys commented 1 day ago

@SMoraisAnsys, documentation build is failing for missing docstrings even if docstrings are there. Do you have any suggestion to help me?

I've looked at the cahnges and it seems that at least 2 classes don't have docstring, see PCBSettingsPackageParts and PCBSettingsDeviceParts