Closed SMoraisAnsys closed 3 days ago
Thanks for opening a Pull Request. If you want to perform a review write a comment saying:
@ansys-reviewer-bot review
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 83.14%. Comparing base (
df9b411
) to head (0ae2cfa
). Report is 4 commits behind head on main.
@nathmay could you give a try at this fix ? I tested locally and it seems to be working fine.
This is an attempt to fix #4844.
@maxcapodi78 The main change is that we both handle
None
and0
as the same kind of result. Indeed,0
seems to be the default value obtained if_desktop_sessions
is empty. Note that I'm not sure if, in the case of existing desktop sessions, we shouldn't use directlyclient.root.check_port()
to definecl.aedt_port
directly. Also, I was wondering how we could try to leverage_desktop_sessions
frompyaedt.generic.desktop_sessions
but I have the feeling that this shouldn't be updated unless aDesktop
is created (which isn't performed right through the callcreate_session
right ?)