search

ansys / pyaedt

AEDT Python Client Package
https://aedt.docs.pyansys.com
MIT License
185 stars 101 forks source link

REFACTOR: Icepak Mesh class initialization performace #4877

Open lorenzovecchietti opened 4 days ago

lorenzovecchietti commented 4 days ago

Close #4876

Big thanks to @leunamedaking for the help in testing the changes.

ansys-reviewer-bot[bot] commented 4 days ago

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

codecov[bot] commented 3 days ago

Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.16%. Comparing base (75c4ec2) to head (a020f20). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4877 +/- ## ========================================== - Coverage 83.17% 83.16% -0.02% ========================================== Files 118 118 Lines 54144 54154 +10 ========================================== + Hits 45034 45035 +1 - Misses 9110 9119 +9 ```
lorenzovecchietti commented 3 days ago

@SMoraisAnsys I excluded from test coverage the lines of code that are related to 23R2 and previous, but is seems that codecov is ignoring the pragma : no cover statement. Why?