search

ansys / pyaedt

AEDT Python Client Package
https://aedt.docs.pyansys.com
MIT License
195 stars 115 forks source link

BUILD: Remove imageio from requirements #4905

Closed maxcapodi78 closed 1 month ago

maxcapodi78 commented 1 month ago

added environment variable in linux extension. Close #4909

ansys-reviewer-bot[bot] commented 1 month ago

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

SMoraisAnsys commented 1 month ago

Are the linux changes related to an issue or something ? Why are they needed ?

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.17%. Comparing base (f541b56) to head (7e6ab04). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4905 +/- ## ========================================== - Coverage 83.18% 83.17% -0.01% ========================================== Files 118 118 Lines 54147 54177 +30 ========================================== + Hits 45041 45064 +23 - Misses 9106 9113 +7 ```
maxcapodi78 commented 1 month ago

Are the linux changes related to an issue or something ? Why are they needed ?

@SMoraisAnsys Yes. I' didn't enter the issue. I've tested yesterday on our Cluster and it happens that if I open AEDT from SLURM or LSF and then launch the console the variables are obviously not there. So I force the add of the variable before initializing the pyaedt console

SMoraisAnsys commented 1 month ago

Seems like imageio is required by pyvista and some test with animated plots are failing.

image

Can you update the PR title to match linux changes and add a comment on imageio in pyproject.toml so that we remember the reason for this requirement ?

SMoraisAnsys commented 1 month ago

@maxcapodi78 In fact, can you update the pyproject.toml file so that we use pyvista[io] (https://github.com/pyvista/pyvista/blob/main/pyproject.toml#L46)