Closed maxcapodi78 closed 1 month ago
Thanks for opening a Pull Request. If you want to perform a review write a comment saying:
@ansys-reviewer-bot review
Are the linux changes related to an issue or something ? Why are they needed ?
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 83.17%. Comparing base (
f541b56
) to head (7e6ab04
). Report is 2 commits behind head on main.
Are the linux changes related to an issue or something ? Why are they needed ?
@SMoraisAnsys Yes. I' didn't enter the issue. I've tested yesterday on our Cluster and it happens that if I open AEDT from SLURM or LSF and then launch the console the variables are obviously not there. So I force the add of the variable before initializing the pyaedt console
Seems like imageio is required by pyvista and some test with animated plots are failing.
Can you update the PR title to match linux changes and add a comment on imageio in pyproject.toml so that we remember the reason for this requirement ?
@maxcapodi78 In fact, can you update the pyproject.toml file so that we use pyvista[io]
(https://github.com/pyvista/pyvista/blob/main/pyproject.toml#L46)
added environment variable in linux extension. Close #4909