search

ansys / pyaedt

AEDT Python Client Package
https://aedt.docs.pyansys.com
MIT License
195 stars 115 forks source link

FIX: plotter show exiting plotting session #4912

Closed SMoraisAnsys closed 1 month ago

SMoraisAnsys commented 1 month ago

Changes consists in handling the fact that some methods are using/returning a plotter and calling show on it. However, the default behavior leads to automatically closing the plotting session when user close the plot.

This PR changes this behavior by using auto_close=False in pyvista's plotter call to method show.

Closes #4730

ansys-reviewer-bot[bot] commented 1 month ago

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.13%. Comparing base (a24bfdb) to head (e72c918). Report is 8 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4912 +/- ## ========================================== - Coverage 83.16% 79.13% -4.03% ========================================== Files 118 118 Lines 54143 54177 +34 ========================================== - Hits 45027 42874 -2153 - Misses 9116 11303 +2187 ```