search

ansys / pyaedt

AEDT Python Client Package
https://aedt.docs.pyansys.com
MIT License
206 stars 126 forks source link

REFACTOR: Leverage type hint and add checking #5194

Open SMoraisAnsys opened 1 month ago

SMoraisAnsys commented 1 month ago

We have deprecated IronPython so we should be able to use type hints ! This will help us to improve code clarity, catch potential bugs early, enhance IDE support (this one is particularly great), simplify maintenance, ...

For example


def retrieve_property(self, property_name: str) -> str :
    pass

Related to https://github.com/ansys/pyaedt/issues/5152

MaxJPRey commented 1 month ago

It is for sure a huge work load, but definitely worth it, especially as you said for development in IDE by our users.

vatsalrathod16 commented 1 month ago

I can work on this issue

SMoraisAnsys commented 1 month ago

I can work on this issue

Hey @vatsalrathod16, thanks for helping us, any contribution is welcome ! This is a HUGE task so I would advise to only work on a subset of the files. Feel free to pick whichever you like 👍

vatsalrathod16 commented 1 month ago

Ok, I will try to complete it part by part.