ansys / pyansys-geometry

A Python wrapper for Ansys Geometry Services
https://geometry.docs.pyansys.com/
MIT License
32 stars 9 forks source link

fix: GetSurface and GetCurve not available prior to 24R2 #1171

Closed RobPasMue closed 1 month ago

RobPasMue commented 1 month ago

Description

Fixing 24R1 related issue due to GetSurface and GetCurve APIs

Issue linked

Closes #1170

Checklist

RobPasMue commented 1 month ago

I believe the comments don't apply @AlejandroFernandezLuces - please review my answers

RobPasMue commented 1 month ago

Thank you both for your reviews!

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 95.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 90.57%. Comparing base (4f4a656) to head (6807dfa).

Files Patch % Lines
src/ansys/geometry/core/connection/client.py 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1171 +/- ## ======================================= Coverage 90.56% 90.57% ======================================= Files 93 93 Lines 6987 6993 +6 ======================================= + Hits 6328 6334 +6 Misses 659 659 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.