ansys / pyansys-geometry

A Python wrapper for Ansys Geometry Services
https://geometry.docs.pyansys.com/
MIT License
46 stars 14 forks source link

feat: allow picking from easy access methods #1499

Closed RobPasMue closed 1 month ago

RobPasMue commented 1 month ago

Description

Allow picking directly from component or body... this requires modifications in visualization tool.

Issue linked

Closes #1498

Checklist

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 37.50000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 91.65%. Comparing base (c4c4d14) to head (d71885f). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/geometry/core/plotting/plotter.py 20.00% 8 Missing :warning:
src/ansys/geometry/core/designer/component.py 66.66% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1499 +/- ## ========================================== - Coverage 91.78% 91.65% -0.13% ========================================== Files 86 86 Lines 6974 6986 +12 ========================================== + Hits 6401 6403 +2 - Misses 573 583 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

RobPasMue commented 1 month ago

Just a small consideration, is the picker example still up to date after these changes? I assume that it is but just in case 🙂

Good point - I also included in the docs the fact that a user could now just say design.plot(allow_picking=True) if they wanted. Also, the example was working fine buuuut... only for Windows. The Linux service was crashing since it does not allow for multiple designs, so I had to change the location of the multi_colors section. Thanks @AlejandroFernandezLuces for the review!