ansys / pyansys-geometry

A Python wrapper for Ansys Geometry Services
https://geometry.docs.pyansys.com/
MIT License
46 stars 14 forks source link

feat: implement cut operation in extrude sketch #1510

Closed RobPasMue closed 3 weeks ago

RobPasMue commented 4 weeks ago

Description

Provide cut argument in extrude_sketch function to allow for subtract operations.

Issue linked

Closes #1503

Checklist

codecov[bot] commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.66%. Comparing base (8b919dd) to head (7af6f6c). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/geometry/core/designer/component.py 94.11% 1 Missing :warning:
src/ansys/geometry/core/misc/measurements.py 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1510 +/- ## ========================================== - Coverage 91.67% 91.66% -0.01% ========================================== Files 86 86 Lines 7001 7018 +17 ========================================== + Hits 6418 6433 +15 - Misses 583 585 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

RobPasMue commented 4 weeks ago

Minor edits suggested--although I see this is a draft. I only looked at it because I was copied on the PR. Sorry!

No problem at all - thanks @PipKat!