Please Review

[akaszynski]

Please conduct a pre-release review for this tools package.

[jleonatti]

First review:

• [x] Can't pip install. See #2.
• [ ] VERSION file under proto-samples\ansys\api\sample\v1 has version 0.5.3. Shouldn't it be something like 1.5.3 since it is under v1?
• [ ] Nit pick: protofile used in README. Prefer proto file.
• [ ] Problem with running tests from virtual environment. See #4.

[jleonatti]

Also, created PR #3 to add missing python packages.

[akaszynski]

VERSION file under proto-samples\ansys\api\sample\v1 has version 0.5.3. Shouldn't it be something like 1.5.3 since it is under v1?

I'm expecting that the proto version to be completely decoupled from the client/server version. For example, Ansys is v21.2 and we're sporting v0 in many of our proto files. I'm not opposed to bumping the version, especially for our example, but at the same time it should be noted that the version of the interface does not need to match the version of the client/server.

Nit pick: protofile used in README. Prefer proto file.

Resolved in #6.

• Problem with running tests from virtual environment. See Error running tests in virtual environment #4.

Resolved in #5.