search

ansys / pyansys-tools-report

Ansys tool for reporting your Python environment's package versions and hardware resources in a standardized way.
https://report.tools.docs.pyansys.com
MIT License
3 stars 0 forks source link

Feat: Adding plotting support or not #136

Closed germa89 closed 8 months ago

germa89 commented 1 year ago

I think the report should include something like:

Plotting support; True/False

This can be done with pyvista. Not sure if we want to have such dependency. We should always, extract that part from the library.

RobPasMue commented 1 year ago

The ansys-tools-report tool package will require PyVista in any case (as a dependency) so... not sure if we can do this.

germa89 commented 1 year ago

I do not like having pyvista as a dependency... but I think that kind of information is useful.

We could do a try on import pyvista and if successful, just show that line or not.

I would also advocate to extract the code for that check from pyvista.

RobPasMue commented 1 year ago

pyvista is a dependency of the package for the GPU check we perform... and we also use scooby which is our main dependency, which also uses pyvista as a dep... so it's going to be almost impossible to "not have" pyvista as a dependency for this package.

germa89 commented 1 year ago

Ohh.. I misunderstood your comment.

In that case including a line in the report that says:

Plotting support; True/False

should be pretty straight forward because pyvista is already a dependency :)

RobPasMue commented 1 year ago

My point is that it will always return True because it will always be a dependency of the ansys-tools-report package...

germa89 commented 1 year ago

Oohh..... you are right. Having pyvista equals plot support. My bad.

germa89 commented 1 year ago

No no.. wait. My bad again.

It is two different things; having pyvista and having plotting support.

For instance we have this PyMAPDL: https://github.com/ansys/pymapdl/blob/5040f1270c1b531723c326bffa36bf95b6f90723/.github/workflows/ci.yml#L98

which shows for the smoke tests: https://github.com/ansys/pymapdl/actions/runs/6532426663/job/17735570170#step:4:43

Plotting support is either a physical display, or having a display buffer (xvfb). So I still think this is useful.

RobPasMue commented 1 year ago

Oh got it... this is something different then.