Closed germa89 closed 8 months ago
The ansys-tools-report tool package will require PyVista in any case (as a dependency) so... not sure if we can do this.
I do not like having pyvista as a dependency... but I think that kind of information is useful.
We could do a try
on import pyvista
and if successful, just show that line or not.
I would also advocate to extract the code for that check from pyvista.
pyvista is a dependency of the package for the GPU check we perform... and we also use scooby which is our main dependency, which also uses pyvista as a dep... so it's going to be almost impossible to "not have" pyvista as a dependency for this package.
Ohh.. I misunderstood your comment.
In that case including a line in the report that says:
Plotting support; True/False
should be pretty straight forward because pyvista is already a dependency :)
My point is that it will always return True
because it will always be a dependency of the ansys-tools-report package...
Oohh..... you are right. Having pyvista equals plot support. My bad.
No no.. wait. My bad again.
It is two different things; having pyvista and having plotting support.
For instance we have this PyMAPDL: https://github.com/ansys/pymapdl/blob/5040f1270c1b531723c326bffa36bf95b6f90723/.github/workflows/ci.yml#L98
which shows for the smoke tests: https://github.com/ansys/pymapdl/actions/runs/6532426663/job/17735570170#step:4:43
Plotting support is either a physical display, or having a display buffer (xvfb
). So I still think this is useful.
Oh got it... this is something different then.
I think the report should include something like:
This can be done with pyvista. Not sure if we want to have such dependency. We should always, extract that part from the library.