ansys / pydpf-composites

A Python wrapper for Ansys DPF for the post-processing of composite structures.
https://composites.dpf.docs.pyansys.com
MIT License
8 stars 1 forks source link

Fix Field Indexer and get_element_indices for layered solids and add example of a thermal analysis #512

Closed roosre closed 1 month ago

roosre commented 1 month ago

While adding an example for a thermal analysis (examples/013_thermal_example.py), several issues were found in the result extraction for layered solid elements where the field indexers are used. The main issue is that fields which have one entry per entity behave slightly different if compared with one that has multiple entries per entity. This became visible because a solid model with "analysis ply-wise" extrusion was used. So there is only one entry per entity for the layered fields such as angles, materials etc.

Here are some details:

greschd commented 1 month ago

General question: are we planning to backport these fixes to the 0.6 release branch and 2024R2 pyansys metapackage?

roosre commented 1 month ago

General question: are we planning to backport these fixes to the 0.6 release branch and 2024R2 pyansys metapackage?

Hi @greschd , yes. That would make sense from my point of view.

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 87.17949% with 15 lines in your changes missing coverage. Please review.

Project coverage is 91.66%. Comparing base (d8d8cc6) to head (83d1310). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/dpf/composites/_indexer.py 83.33% 15 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #512 +/- ## ========================================== - Coverage 92.21% 91.66% -0.55% ========================================== Files 50 50 Lines 3352 3397 +45 ========================================== + Hits 3091 3114 +23 - Misses 261 283 +22 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.