search

ansys / pydpf-core

Data Processing Framework - Python Core
http://dpf.docs.pyansys.com/
MIT License
68 stars 25 forks source link

Remove a test due to changes on eCONTA174 (consider as linear/quadratic instead of semi parabolic) #1746

Closed MichaelNale closed 1 month ago

MichaelNale commented 2 months ago

Change server side the eleType related to eCONTA174. We used to consider it as semi parabolic if he was surrounded by linear elements and that lead to inconsistency (for example to compute element::volume). Now, regarding this, we linearize this element or keep it quadratic.

rafacanton commented 2 months ago

@MichaelNale I guess that when the changes are ported to core, you will create a new test that tests these functionalities, right?

MichaelNale commented 2 months ago

@rafacanton At the end I can just update to reflect the fact that these elements are not semi parabolic anymore. Here it will be just assert dpf.core.element_types.descriptor(el.type).n_nodes = len(el.connectivity).

rafacanton commented 2 months ago

@rafacanton At the end I can just update to reflect the fact that these elements are not semi parabolic anymore. Here it will be just assert dpf.core.element_types.descriptor(el.type).n_nodes = len(el.connectivity).

I was referring to the opposite. Instead of changing this test to ensure that this element is no longer semiparabolic, you can also find a proper semiparabolic element in another model and test the same assertion (and that way you are still covering the scenario of this test!)