ansys / pydpf-post

Data Processing Framework - Post Processing Module

https://post.docs.pyansys.com

MIT License

43 stars 10 forks source link

Implementing vale #143

Closed RobPasMue closed 2 years ago

RobPasMue commented 2 years ago

Resolves #142

codecov[bot] commented 2 years ago

Codecov Report

Merging #143 (8222332) into master (78246f2) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #143   +/-   ##
=======================================
  Coverage   83.60%   83.60%           
=======================================
  Files          25       25           
  Lines        1348     1348           
=======================================
  Hits         1127     1127           
  Misses        221      221

RobPasMue commented 2 years ago

@PipKat with this implementation of vale, it is not part of the main CI/CD workflow. Users have to execute manually the workflow to run the vale checks. I will show you how to do it. However, you will always be able to run vale locally in your machine.

Pinging @akaszynski following our previous discussions on how to implement vale in order not to harass developers on a daily basis. This is probably the best compromise.

The same applies to https://github.com/pyansys/pydpf-core/pull/424