ansys / pydpf-post

Data Processing Framework - Post Processing Module

https://post.docs.pyansys.com

MIT License

43 stars 10 forks source link

Doc/overall edit dpf post #144

Closed PipKat closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #144 (8a28b4a) into master (c96c244) will increase coverage by 0.17%. The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
+ Coverage   83.60%   83.77%   +0.17%     
==========================================
  Files          25       25              
  Lines        1348     1350       +2     
==========================================
+ Hits         1127     1131       +4     
+ Misses        221      219       -2

PipKat commented 2 years ago

@RobPasMue Well it took me a very long time, but I finally got all the checks by codecov/patch to run successfully. I don't know anything about this area, so I will leave it to you to handle on Monday. Thanks!

RobPasMue commented 2 years ago

Hi @PipKat! It definitely looks good! Regarding the codecov failed check, it looks like no test is going through a line you modified, but it is definitely not your fault - a test should have been created to pass through that line. I think after review, we can merge despite this stage failing. @PProfizi do you agree?