Closed GuillemBarroso closed 1 year ago
Merging #233 (6e37a7e) into post_refactor (89fdadf) will increase coverage by
3.57%
. The diff coverage is86.36%
.
@@ Coverage Diff @@
## post_refactor #233 +/- ##
=================================================
+ Coverage 74.89% 78.46% +3.57%
=================================================
Files 30 30
Lines 1665 1709 +44
=================================================
+ Hits 1247 1341 +94
+ Misses 418 368 -50
Things to be improved:
Several things can be improved in this PR, although I think it would be better to do it in separate PRs once this one is merged.
- Improve print of
DataObject
andField
. Right now, the prints have references to FieldsContainer and Fields. This should be hidden in PyDPF-Post (the users of Post should not have to know what are the Field or FieldsContainer objects).- Display component of the field ("X", "XZ", etc ) in plot's colorbar. Right now only the field name (displacement, stress) is shown.
- Expose displaying the available named selections in Simulation object.
- For transient solutions, I added some lines in
simulation.py
in order to return all time steps when notime_scoping
is specified. However, this makes theDataObjet
to have integer times instead of the actual time step values, see image below.- For transient simulations, the user should be able to select time steps using time values (float) and not only step number (int).
@GuillemBarroso I agree with your suggestions. Indeed this can be done in separate PRs.
Closing as stale
Fix #232.
Changes proposed in this PR:
data_object.py
: improvements on the object.simulation.py
: add stresses02-get_data_from_static_simulation.py
: example on how to retrieve data from static simulation03-get_data_from_transient_simulation.py
: example on how to retrieve data from transient simulationThings to be improved:
Several things can be improved in this PR, although I think it would be better to do it in separate PRs once this one is merged.
DataObject
andField
. Right now, the prints have references to FieldsContainer and Fields. This should be hidden in PyDPF-Post (the users of Post should not have to know what are the Field or FieldsContainer objects).simulation.py
in order to return all time steps when notime_scoping
is specified. However, this makes theDataObjet
to have integer times instead of the actual time step values, see image below.Instead, it should be displayed as: