Closed PProfizi closed 1 year ago
Merging #279 (5f50e08) into master (3f89cfe) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #279 +/- ##
=======================================
Coverage 83.64% 83.64%
=======================================
Files 25 25
Lines 1351 1351
=======================================
Hits 1130 1130
Misses 221 221
Hi @RobPasMue I am trying to fix the problem with pre-commit and isort you mentioned. I tried updating the Style Check step in our CI to match what is done in the pyansys action yet it is not enough.
Does this mean I have to pin isort=5.12.0
somewhere? It does not appear anywhere right now and the pip install pre-commit
step does not even seem to install isort
.
HI @PProfizi! Let me fix this quickly. Steps to reproduce my upcoming changes are:
pre-commit autoupdate
pre-commit run --all-files
The version has to be changed at the pre-commit-config.yaml
file. Your Python version was fine as it was, no worries about that.
This should work now 😄 thanks for pinging me @PProfizi
Thank you so much @RobPasMue!
@RobPasMue one question though: I thought dependabot would deal with the pre-commit.yaml dependencies, yet I guess I haven't plugged this in.
@RobPasMue one question though: I thought dependabot would deal with the pre-commit.yaml dependencies, yet I guess I haven't plugged this in.
Sorry, just checked, and it does not support it yet I think.
Nope, that's not supported. What we can do is set up pre-commit.ci though. This tool will automatically open pre-commit related update PRs on a weekly basis. And it will also allow you to remove the style-checks step of your workflows since it runs on cached runners always. See this issue for a summary of the benefits: https://github.com/pyansys/pyfluent/issues/1253
If you wanted it on your repository let me know and I can help you set it up 😄
Pre-commit step is currently failing due to new version of
isort
not being used. Add update command when installing pre-commit.