search

ansys / pydpf-post

Data Processing Framework - Post Processing Module
https://post.docs.pyansys.com
MIT License
43 stars 10 forks source link

Improvements to pyproject.toml - contact email #328

Closed RobPasMue closed 1 year ago

RobPasMue commented 1 year ago

At the https://github.com/pyansys/pyansys-dev package we are experiencing some issues with a recent modification to your pyproject.toml file...

We have the feeling that it may be caused by the fact that you may be calling the entire repository as a dependency, while we are targeting a specific branch (master). In any case, if you want to leave it as it was, it would also be fine. It'd be more accurrate to just target the master branch on your side for this use case.

codecov[bot] commented 1 year ago

Codecov Report

Merging #328 (7c8e4a4) into master (0aaf55f) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #328   +/-   ##
=======================================
  Coverage   82.68%   82.68%           
=======================================
  Files          35       35           
  Lines        3170     3170           
=======================================
  Hits         2621     2621           
  Misses        549      549
RobPasMue commented 1 year ago

Nah, probably not needed... Let me revert them. But the contact email should be changed in any case :)

PProfizi commented 1 year ago

Nah, probably not needed... Let me revert them. But the contact email should be changed in any case :)

Thank you for the changes! This direct dependency to the git repo for ansys-dpf-core dates back to the addition of the pyproject.toml. I think it clones the repo and checks-out master, but since master is default, I do not think it downloads more than needed.