Closed PProfizi closed 1 year ago
Merging #339 (9e1ca0d) into master (5c5d79a) will decrease coverage by
0.06%
. The diff coverage is100.00%
.:exclamation: Current head 9e1ca0d differs from pull request most recent head c1d2104. Consider uploading reports for the commit c1d2104 to get more accurate results
@@ Coverage Diff @@
## master #339 +/- ##
==========================================
- Coverage 82.72% 82.66% -0.06%
==========================================
Files 35 35
Lines 3184 3173 -11
==========================================
- Hits 2634 2623 -11
Misses 550 550
The ANSYS_VERSION input in retro tests in ci.yml and ci_release.yml was set to env.ANSYS_VERSION instead of matrix.ANSYS_VERSION, meaning retro tests actually ran on the latest server.
Once this is rectified, it appears that operator
extract_scoping
is too recent to be used. It is in the code at:_get_result
for each Simulation variant -> Actually unused, remove useless code inHarmonicMechanicalSimulation
,ModalMechanicalSimulation
andTransientMechanicalSimulation
MeshIndex._evaluate_values
in caseself._scoping_ref is None
-> implement a retro-compatible (slower) version when DPF<5.0