search

ansys / pydpf-post

Data Processing Framework - Post Processing Module
https://post.docs.pyansys.com
MIT License
43 stars 10 forks source link

Bump pyvista from 0.38.5 to 0.41.1 #448

Closed dependabot[bot] closed 1 year ago

dependabot[bot] commented 1 year ago

Bumps pyvista from 0.38.5 to 0.41.1.

Release notes

Sourced from pyvista's releases.

v0.40.0

This release is marked by dramatic improvements to PyVista's Trame-powered Jupyter backend, default theming, picking capabilities, and significant maintenance to improve PyVista's long-term sustainability.

What's Changed

Breaking Changes

New Features

Bug fixes or behavior changes

Documentation

Maintenance

... (truncated)

Commits


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
codecov[bot] commented 1 year ago

Codecov Report

Merging #448 (e22d324) into master (60da6a2) will decrease coverage by 0.07%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #448      +/-   ##
==========================================
- Coverage   83.56%   83.50%   -0.07%     
==========================================
  Files          45       45              
  Lines        4971     4971              
==========================================
- Hits         4154     4151       -3     
- Misses        817      820       +3
PProfizi commented 1 year ago

Getting this error for all examples at example doc generation:

WARNING: /home/runner/work/pydpf-post/pydpf-post/examples/00-Different-analysis-types/02-modal-simulation.py failed to execute correctly: Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.8.17/x64/lib/python3.8/site-packages/sphinx_gallery/scrapers.py", line 340, in save_figures
    rst = scraper(block, block_vars, gallery_conf)
  File "/opt/hostedtoolcache/Python/3.8.17/x64/lib/python3.8/site-packages/pyvista/plotting/utilities/sphinx_gallery.py", line 132, in __call__
    return html_rst(image_names, gallery_conf["src_dir"])
  File "/opt/hostedtoolcache/Python/3.8.17/x64/lib/python3.8/site-packages/pyvista/plotting/utilities/sphinx_gallery.py", line 49, in html_rst
    raise RuntimeError("Only one figure per output is supported for now.")
RuntimeError: Only one figure per output is supported for now.

@AlejandroFernandezLuces can it be an issue of incompatibility with the latest PyVista and latest sphinx-gallery? The first expects only one image per example, the second gives several?

AlejandroFernandezLuces commented 1 year ago

Getting this error for all examples at example doc generation:

WARNING: /home/runner/work/pydpf-post/pydpf-post/examples/00-Different-analysis-types/02-modal-simulation.py failed to execute correctly: Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.8.17/x64/lib/python3.8/site-packages/sphinx_gallery/scrapers.py", line 340, in save_figures
    rst = scraper(block, block_vars, gallery_conf)
  File "/opt/hostedtoolcache/Python/3.8.17/x64/lib/python3.8/site-packages/pyvista/plotting/utilities/sphinx_gallery.py", line 132, in __call__
    return html_rst(image_names, gallery_conf["src_dir"])
  File "/opt/hostedtoolcache/Python/3.8.17/x64/lib/python3.8/site-packages/pyvista/plotting/utilities/sphinx_gallery.py", line 49, in html_rst
    raise RuntimeError("Only one figure per output is supported for now.")
RuntimeError: Only one figure per output is supported for now.

@AlejandroFernandezLuces can it be an issue of incompatibility with the latest PyVista and latest sphinx-gallery? The first expects only one image per example, the second gives several?

I see that other repos already have this configuration without any problems: https://github.com/ansys/pygeometry/blob/604f46099708e690255dc93589185f3a0b067a28/pyproject.toml#L82-L84 https://github.com/ansys/pyaedt/blob/05c2b97a4400b4f8e431bb62d409b6110f0121f6/pyproject.toml#L77-L81

Are you aware if PyDPF docs have any special requirements? On first sight I see that most of your examples have several plots per piece of code, in contrast to other libraries, that only have one plot per piece of code:

Example: https://aedt.docs.pyansys.com/version/stable/examples/00-EDB/08_CPWG.html#start-hfss-solver https://post.docs.pyansys.com/version/stable/examples/01-Detailed-Examples/01-named-selections-modal-simulation.html#extract-displacements-on-named-selections

The issue might arise with this setup. Could you try to set up an example with only one plot per piece of code to see if that is what causes PyVista to fail?

PProfizi commented 1 year ago

@AlejandroFernandezLuces thank you so much for your analysis. I'll test having only one plot per code section. Do you think however that this "for now" is expected to be implemented soon? https://github.com/pyvista/pyvista/blob/15ba91a27c28857b73affa58d6e76d0ce0119f1a/pyvista/plotting/utilities/sphinx_gallery.py#L49C79-L49C79

Sure we can set one plot per section, or even try to do multi-plots to have only one resulting image, yet as-is this is a limitation and a restriction that we are going to have to enforce when people create examples.

AlejandroFernandezLuces commented 1 year ago

@AlejandroFernandezLuces thank you so much for your analysis. I'll test having only one plot per code section. Do you think however that this "for now" is expected to be implemented soon? https://github.com/pyvista/pyvista/blob/15ba91a27c28857b73affa58d6e76d0ce0119f1a/pyvista/plotting/utilities/sphinx_gallery.py#L49C79-L49C79

Sure we can set one plot per section, or even try to do multi-plots to have only one resulting image, yet as-is this is a limitation and a restriction that we are going to have to enforce when people create examples.

We can request the feature but it might take a while to be implemented. Personally I would enforce new examples to have one plot per section.

dependabot[bot] commented 1 year ago

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

PProfizi commented 1 year ago

See #454